1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QDomNodeList: mark op==(Private) noexcept

Browse Source 
It is, because it only compares a pointer and a string, both of which
are nothrow_equality_comparable.

Also remove the unused (even in C++17 mode) inequality operator
instead of marking it noexcept, too.

Pick-to: 6.5 6.2
Change-Id: I0ce62df02ffc98252d17cef659cc6dc2a90ae2cf
Reviewed-by: Rym Bouabid <rym.bouabid@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
(cherry picked from commit 3fce04157dbba1232d96821dbb166c6a5dc467a8)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2024-11-06 11:37:02 +01:00 committed by Qt Cherry-pick Bot
parent 3502790551
commit 78dfb5f196
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/xml/dom/qdom.cpp
View File

@ -639,16 +639,11 @@ QDomNodeListPrivate::~QDomNodeListPrivate()
delete node_impl; delete node_impl;
} }
bool QDomNodeListPrivate::operator==(const QDomNodeListPrivate &other) const bool QDomNodeListPrivate::operator==(const QDomNodeListPrivate &other) const noexcept
{ {
return (node_impl == other.node_impl) && (tagname == other.tagname); return (node_impl == other.node_impl) && (tagname == other.tagname);
} }
bool QDomNodeListPrivate::operator!=(const QDomNodeListPrivate &other) const
{
return !operator==(other);
}
void QDomNodeListPrivate::createList() const void QDomNodeListPrivate::createList() const
{ {
if (!node_impl) if (!node_impl)

3
src/xml/dom/qdom_p.h
View File

@ -140,8 +140,7 @@ public:
QDomNodeListPrivate(QDomNodePrivate *, const QString &, const QString &); QDomNodeListPrivate(QDomNodePrivate *, const QString &, const QString &);
~QDomNodeListPrivate(); ~QDomNodeListPrivate();
bool operator==(const QDomNodeListPrivate &) const; bool operator==(const QDomNodeListPrivate &) const noexcept;
bool operator!=(const QDomNodeListPrivate &) const;
void createList() const; void createList() const;
bool maybeCreateList() const; bool maybeCreateList() const;