1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QCommonStyle: use logging categories

Browse Source 
Use qCWarning instead of qWarning, to give users more control over
debug output if needed.

Fixes: QTBUG-105332
Change-Id: I830dd160f75eb9885d80b80336bfb27da676e4bc
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
This commit is contained in:
Timur Pocheptsov 2022-08-05 14:53:20 +02:00
parent 38ca34ac93
commit 75d4958e50
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/widgets/styles/qcommonstyle.cpp
View File

@ -78,6 +78,8 @@
#include <private/qstyleanimation_p.h> #include <private/qstyleanimation_p.h>
#endif #endif
#include <qloggingcategory.h>
#include <limits.h> #include <limits.h>
#include <private/qtextengine_p.h> #include <private/qtextengine_p.h>
@ -85,6 +87,8 @@
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
Q_LOGGING_CATEGORY(lcCommonStyle, "qt.widgets.commonstyle");
using namespace Qt::StringLiterals; using namespace Qt::StringLiterals;
static qreal qt_getDevicePixelRatio(const QWidget *widget) static qreal qt_getDevicePixelRatio(const QWidget *widget)
@ -1104,7 +1108,7 @@ void QCommonStylePrivate::viewItemLayout(const QStyleOptionViewItem *opt, QRect
} }
break; } break; }
default: default:
qWarning("doLayout: decoration position is invalid"); qCWarning(lcCommonStyle, "doLayout: decoration position is invalid");
decoration = *pixmapRect; decoration = *pixmapRect;
break; break;
} }
@ -3875,7 +3879,7 @@ void QCommonStyle::drawComplexControl(ComplexControl cc, const QStyleOptionCompl
break; break;
#endif // QT_CONFIG(mdiarea) #endif // QT_CONFIG(mdiarea)
default: default:
qWarning("QCommonStyle::drawComplexControl: Control %d not handled", cc); qCWarning(lcCommonStyle, "QCommonStyle::drawComplexControl: Control %d not handled", cc);
} }
} }
@ -4011,7 +4015,7 @@ QStyle::SubControl QCommonStyle::hitTestComplexControl(ComplexControl cc, const
} }
break; break;
default: default:
qWarning("QCommonStyle::hitTestComplexControl: Case %d not handled", cc); qCWarning(lcCommonStyle, "QCommonStyle::hitTestComplexControl: Case %d not handled", cc);
} }
return sc; return sc;
} }
@ -4450,7 +4454,7 @@ QRect QCommonStyle::subControlRect(ComplexControl cc, const QStyleOptionComplex
} }
#endif // QT_CONFIG(mdiarea) #endif // QT_CONFIG(mdiarea)
default: default:
qWarning("QCommonStyle::subControlRect: Case %d not handled", cc); qCWarning(lcCommonStyle, "QCommonStyle::subControlRect: Case %d not handled", cc);
} }
#if !QT_CONFIG(slider) && !QT_CONFIG(spinbox) && !QT_CONFIG(toolbutton) && !QT_CONFIG(groupbox) #if !QT_CONFIG(slider) && !QT_CONFIG(spinbox) && !QT_CONFIG(toolbutton) && !QT_CONFIG(groupbox)
Q_UNUSED(widget); Q_UNUSED(widget);