From 73d00d05477fb6da25164b37135bb19a300bea8d Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 25 Mar 2024 07:46:52 +0100 Subject: [PATCH] syncqt: remove dead code Either the code in the try {} block - doesn't throw, then the return within the try {} block exits the function, or it - throws fileystem_error, then we rethrow in the catch, or it - throws any other exception, then we leave the function by exception In no case can control reach the trailing 'return {}'. Found by Coverity. Amends 7aecb189d544613ad13c7e7d1207bd7767225a71. Pick-to: 6.7 6.6 6.5 Coverity-Id: 444466 Change-Id: I1c1bf752453076724c2fa9367ea5309e741d84ac Reviewed-by: Alexey Edelev --- src/tools/syncqt/main.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tools/syncqt/main.cpp b/src/tools/syncqt/main.cpp index db59a3c7ad0..5df7b03fd54 100644 --- a/src/tools/syncqt/main.cpp +++ b/src/tools/syncqt/main.cpp @@ -151,7 +151,6 @@ std::filesystem::path normilizedPath(const std::string &path) printFilesystemError(fserr, "Unable to normalize path"); throw; } - return {}; } bool createDirectories(const std::string &path, std::string_view errorMsg, bool *exists = nullptr)