From 735a864360ddacae720c198094735c3e3692f5c3 Mon Sep 17 00:00:00 2001 From: Laszlo Agocs Date: Wed, 23 Aug 2023 17:57:16 +0200 Subject: [PATCH] QRhiWidget: Use QRhiRenderTarget as the return type for renderTarget There is no point in using the more specialized derived class (QRhiTextureRenderTarget), even though that is what the rt always is. None of the example and test code needs changes since relying on QRhiTextureRenderTarget specifics is very rare in practice (now it will need a static_cast), whereas in the majority of cases the return value is passed on to other functions, for example, beginPass(), that take a QRhiRenderTarget. Change-Id: Ifaebb6320a156ec6a9013e72fede04e520aa9aaf Reviewed-by: Qt CI Bot Reviewed-by: Andy Nichols --- src/widgets/kernel/qrhiwidget.cpp | 2 +- src/widgets/kernel/qrhiwidget.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/widgets/kernel/qrhiwidget.cpp b/src/widgets/kernel/qrhiwidget.cpp index 742e0ad6aac..f9edd67ab8a 100644 --- a/src/widgets/kernel/qrhiwidget.cpp +++ b/src/widgets/kernel/qrhiwidget.cpp @@ -1259,7 +1259,7 @@ QRhiRenderBuffer *QRhiWidget::depthStencilBuffer() const \sa colorTexture(), depthStencilBuffer() */ -QRhiTextureRenderTarget *QRhiWidget::renderTarget() const +QRhiRenderTarget *QRhiWidget::renderTarget() const { Q_D(const QRhiWidget); return d->renderTarget; diff --git a/src/widgets/kernel/qrhiwidget.h b/src/widgets/kernel/qrhiwidget.h index 592c35e737c..ace4b18e6b5 100644 --- a/src/widgets/kernel/qrhiwidget.h +++ b/src/widgets/kernel/qrhiwidget.h @@ -12,7 +12,7 @@ class QRhiWidgetPrivate; class QRhi; class QRhiTexture; class QRhiRenderBuffer; -class QRhiTextureRenderTarget; +class QRhiRenderTarget; class QRhiCommandBuffer; class Q_WIDGETS_EXPORT QRhiWidget : public QWidget @@ -80,7 +80,7 @@ public: QRhiRenderBuffer *msaaColorBuffer() const; QRhiTexture *resolveTexture() const; QRhiRenderBuffer *depthStencilBuffer() const; - QRhiTextureRenderTarget *renderTarget() const; + QRhiRenderTarget *renderTarget() const; Q_SIGNALS: void frameSubmitted();