From 713fad1c588b09296e6a358ff2b15fc36b2bc640 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 6 Jul 2021 07:39:09 +0200 Subject: [PATCH] QCryptographicHash: don't allocate a Private in hash() Just create it on the stack, we know the lifetime. Reduces memory allocations in static hash() from 2 to 1. Change-Id: Ie0e22b023331da9a6f39c80b4cd1a5c016f63a87 Reviewed-by: Lars Knoll --- src/corelib/tools/qcryptographichash.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/tools/qcryptographichash.cpp b/src/corelib/tools/qcryptographichash.cpp index ffa3e415e38..f5c5cbb2043 100644 --- a/src/corelib/tools/qcryptographichash.cpp +++ b/src/corelib/tools/qcryptographichash.cpp @@ -665,9 +665,9 @@ QByteArray QCryptographicHashPrivate::finalize() */ QByteArray QCryptographicHash::hash(QByteArrayView data, Algorithm method) { - QCryptographicHash hash(method); + QCryptographicHashPrivate hash(method); hash.addData(data); - return hash.result(); + return hash.finalize(); } /*!