From 71203b1f0ec2da27d4cc03a82162eb7f643cc525 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Mon, 20 Apr 2015 18:30:07 +0200 Subject: [PATCH] Fix overflow in rgb30 gradient tests The tests were trying to access one pixel outside of the image. Change-Id: Ieabdefbbdb76bb736214a0495bec72c881b27d2c Reviewed-by: Gunnar Sletta --- tests/auto/gui/painting/qpainter/tst_qpainter.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/auto/gui/painting/qpainter/tst_qpainter.cpp b/tests/auto/gui/painting/qpainter/tst_qpainter.cpp index 53e9ad6f20e..e13a6b026d7 100644 --- a/tests/auto/gui/painting/qpainter/tst_qpainter.cpp +++ b/tests/auto/gui/painting/qpainter/tst_qpainter.cpp @@ -3978,9 +3978,9 @@ void tst_QPainter::linearGradientRgb30() painter.fillRect(image.rect(), gradient); painter.end(); - for (int i = 0; i < 1000; ++i) { - QColor p1 = image.pixelColor(i, 0); - QColor p2 = image.pixelColor(i + 1, 0); + for (int i = 1; i < 1000; ++i) { + QColor p1 = image.pixelColor(i - 1, 0); + QColor p2 = image.pixelColor(i, 0); QVERIFY(p1 != p2); QVERIFY(qGray(p1.rgb()) >= qGray(p2.rgb())); } @@ -4005,9 +4005,9 @@ void tst_QPainter::radialGradientRgb30() painter.fillRect(image.rect(), gradient); painter.end(); - for (int i = 0; i < 1000; ++i) { - QColor p1 = image.pixelColor(i, 0); - QColor p2 = image.pixelColor(i + 1, 0); + for (int i = 1; i < 1000; ++i) { + QColor p1 = image.pixelColor(i - 1, 0); + QColor p2 = image.pixelColor(i, 0); QVERIFY(p1 != p2); QVERIFY(qGray(p1.rgb()) >= qGray(p2.rgb())); }