From 705e4e63c6ce26507d930428b8cf0d0f137bf3e5 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Wed, 7 Jun 2023 16:25:59 +0200 Subject: [PATCH] XBEL example: Fix null dereference bug As readXBEL() does call readSeparator(nullptr), the latter should cope with being passed nullptr as item. Pick-to: 6.6 6.5 Task-number: QTBUG-111228 Change-Id: I786e4438b566438448b5d54ff6442c27f1255aa8 Reviewed-by: Ievgenii Meshcheriakov --- examples/corelib/serialization/streambookmarks/xbelreader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/corelib/serialization/streambookmarks/xbelreader.cpp b/examples/corelib/serialization/streambookmarks/xbelreader.cpp index ccfa697e136..6e96cb9a059 100644 --- a/examples/corelib/serialization/streambookmarks/xbelreader.cpp +++ b/examples/corelib/serialization/streambookmarks/xbelreader.cpp @@ -81,7 +81,7 @@ void XbelReader::readSeparator(QTreeWidgetItem *item) Q_ASSERT(xml.isStartElement() && xml.name() == QLatin1String("separator")); QTreeWidgetItem *separator = createChildItem(item); - separator->setFlags(item->flags() & ~Qt::ItemIsSelectable); + separator->setFlags(item ? item->flags() & ~Qt::ItemIsSelectable : Qt::ItemFlags{}); separator->setText(0, QString(30, u'\xB7')); xml.skipCurrentElement(); }