1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MySQL: pedantism: create and destroy the MYSQL_TIME type

Browse Source 
This is a no-op. But take the opportunity to make a drive-by update on
the loop, which improves it.

Change-Id: I4a40ccbd3321467a8429fffd169b08590d28c928
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
This commit is contained in:
Thiago Macieira 2021-08-13 18:34:28 -07:00
parent ddea7e6ce9
commit 6feb289189
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/sqldrivers/mysql/qsql_mysql.cpp
View File

@ -375,6 +375,8 @@ bool QMYSQLResultPrivate::bindInValues()
char *field = bind->buffer_length ? new char[bind->buffer_length + 1]{} : nullptr; char *field = bind->buffer_length ? new char[bind->buffer_length + 1]{} : nullptr;
bind->buffer = f.outField = field; bind->buffer = f.outField = field;
if (qIsTimeOrDate(fieldInfo->type))
new (field) MYSQL_TIME;
++i; ++i;
} }
@ -425,9 +427,11 @@ void QMYSQLResult::cleanup()
d->meta = 0; d->meta = 0;
} }
int i; for (const auto &field : qAsConst(d->fields)) {
for (i = 0; i < d->fields.count(); ++i) if (qIsTimeOrDate(field.myField->type))
delete[] d->fields[i].outField; reinterpret_cast<MYSQL_TIME *>(field.outField)->~MYSQL_TIME();
delete[] field.outField;
}
if (d->outBinds) { if (d->outBinds) {
delete[] d->outBinds; delete[] d->outBinds;