From 6f8c0a09ad881d5f58ff8e9cb3f904f88863eeaf Mon Sep 17 00:00:00 2001 From: Axel Spoerl Date: Tue, 30 May 2023 09:01:24 +0200 Subject: [PATCH] QXmlStreamReader: Add key/value to "Invalid attribute" error message When QXmlReaderPrivate::startDocument() parses declarations, it reports an error if a declaration contains an unknown attribute. The message doesn't mention the invalid attribute's key and value, so the user has to guess which one is the faulty declaration. This patch extends the error message by adding the respective key/value pair. Change-Id: I7f5a228bed44937472880c3b3d63d5e816b39361 Reviewed-by: Shawn Rutledge (cherry picked from commit 27906b7da84c22b244b612a557f57606d8d4d626) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/serialization/qxmlstream.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/serialization/qxmlstream.cpp b/src/corelib/serialization/qxmlstream.cpp index eb54fac1bf0..6b36b0121f8 100644 --- a/src/corelib/serialization/qxmlstream.cpp +++ b/src/corelib/serialization/qxmlstream.cpp @@ -1812,7 +1812,7 @@ void QXmlStreamReaderPrivate::startDocument() else err = QXmlStream::tr("Standalone accepts only yes or no."); } else { - err = QXmlStream::tr("Invalid attribute in XML declaration."); + err = QXmlStream::tr("Invalid attribute in XML declaration: %1 = %2").arg(key).arg(value); } }