From 6f0b55e2928a874e6d79fc67c9f5c999cf8a7b6e Mon Sep 17 00:00:00 2001 From: Tian Shilin Date: Wed, 21 Aug 2024 16:41:56 +0800 Subject: [PATCH] fix: Redundant condition in cacheSaveDevice If cacheSaveDevice is false, then if must be true; if cacheSaveDevice is true, then only need to judge whether !cacheSaveDevice->isOpen() is true or not, so the second judgment condition on cacheSaveDevice I think it is not necessary.eg: '!A || (A && B)' is equivalent to '!A || B' Change-Id: I5201d54017d2457ba4b92ee99bb968a0961ccbb9 Reviewed-by: Alexey Edelev (cherry picked from commit 3ecbf28aa6ee43fe967ef219f909f3784e5b3d26) Reviewed-by: Qt Cherry-pick Bot --- src/network/access/qnetworkreplyimpl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/access/qnetworkreplyimpl.cpp b/src/network/access/qnetworkreplyimpl.cpp index b90ec1cc4c6..509dd0621bd 100644 --- a/src/network/access/qnetworkreplyimpl.cpp +++ b/src/network/access/qnetworkreplyimpl.cpp @@ -437,7 +437,7 @@ void QNetworkReplyImplPrivate::initCacheSaveDevice() cacheSaveDevice = networkCache()->prepare(metaData); - if (!cacheSaveDevice || (cacheSaveDevice && !cacheSaveDevice->isOpen())) { + if (!cacheSaveDevice || !cacheSaveDevice->isOpen()) { if (Q_UNLIKELY(cacheSaveDevice && !cacheSaveDevice->isOpen())) qCritical("QNetworkReplyImpl: network cache returned a device that is not open -- " "class %s probably needs to be fixed",