From 6ea2657ad50791b638e8bc2f2e4dc8f93819d30b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Lefebvre?= Date: Tue, 18 Feb 2025 15:47:58 +0100 Subject: [PATCH] Skip tst_QDialog::keepPositionOnClose on Linux as meant for Windows bug The auto-test tst_QDialog::keepPositionOnClose() was meant to verify a bug relating to Windows. It is flaky on Linux Opensuse and flakes when it should be passsing. QSkip this test, as it was written to cover the QTBUG-79147 on Windows and is flaky on Opensuse 15. Fixes: QTBUG-133825 Change-Id: If06bef395248071779bcee234dbb0476ab1ef711 Reviewed-by: Axel Spoerl --- tests/auto/widgets/dialogs/qdialog/tst_qdialog.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/auto/widgets/dialogs/qdialog/tst_qdialog.cpp b/tests/auto/widgets/dialogs/qdialog/tst_qdialog.cpp index e970ea2810a..381872c46bc 100644 --- a/tests/auto/widgets/dialogs/qdialog/tst_qdialog.cpp +++ b/tests/auto/widgets/dialogs/qdialog/tst_qdialog.cpp @@ -568,6 +568,10 @@ void tst_QDialog::dialogInGraphicsView() // bar would offset the dialog position when shown next time. void tst_QDialog::keepPositionOnClose() { +#ifdef Q_OS_LINUX + if (QString(QGuiApplication::platformName().toLower()) == QStringLiteral("xcb")) + QSKIP("Test has been written for Windows and is flaky on Linux xcb."); +#endif QDialog dialog; dialog.setWindowTitle(QTest::currentTestFunction()); const QRect availableGeometry = QGuiApplication::primaryScreen()->availableGeometry();