From 6c9cba45caeb5a9bc519b490b9efd4f3f8ad7281 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 15 Aug 2023 14:20:23 +0200 Subject: [PATCH] tst_macdeplyqt: unbreak runVerifyDeployment() Amends f2f8820073488c89fb71e3eb2d2e87bb582c3995. I have no idea how this went through the CI, but assigning to a const variable cannot possibly compile. Reported-by: Axel Spoerl Task-nubmber: QTBUG-115839 Change-Id: I0f22dcd5ab691f92880ea3c6446aedca53df0721 Reviewed-by: Axel Spoerl (cherry picked from commit c0a38066095b3ed28281391e75c251709f875f53) Reviewed-by: Marc Mutz Reviewed-by: Alexey Edelev --- tests/auto/tools/macdeployqt/tst_macdeployqt.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp b/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp index 3953452bf84..3125d7076e2 100644 --- a/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp +++ b/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp @@ -200,10 +200,10 @@ void runVerifyDeployment(const QString &name) const QString qtPath = QLibraryInfo::path(QLibraryInfo::PrefixPath); // Let assume Qt is not installed in system for (const QString &part : parts) { - part = part.trimmed(); - if (part.isEmpty()) + const auto trimmed = part.trimmed(); + if (trimmed.isEmpty()) continue; - QVERIFY(!part.startsWith(qtPath)); + QVERIFY(!trimmed.startsWith(qtPath)); } }