1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove bogus portion of unit test

Browse Source 
In Qt 4, QSignalSpy didn't *really* connect to the signal it was
spying on. See the "we need to connect the signal somewhere in order
for D-Bus to enable the rules" comments.

In Qt 5, it connects, which rendered this section of the test bogus:
since the signal is still connected, the QSignalSpy will notice that
fact and will not be empty. This is passing due to a false
positive. The upcoming fix breaks it, so we need to remove it.

Change-Id: Ic8fbf7d0e941403e97149f5bc392334a52c66ab1
Reviewed-by: Lorn Potter <lorn.potter@jollamobile.com>
This commit is contained in:
Thiago Macieira 2013-03-13 11:50:46 -07:00 committed by The Qt Project
parent d8bef6bb2e
commit 6c48b9ad87
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/auto/dbus/qdbusabstractinterface/tst_qdbusabstractinterface.cpp
View File

@ -1017,18 +1017,6 @@ void tst_QDBusAbstractInterface::followSignal()
// now the signal must have been received: // now the signal must have been received:
QCOMPARE(s.size(), 1); QCOMPARE(s.size(), 1);
QVERIFY(s.at(0).size() == 0); QVERIFY(s.at(0).size() == 0);
s.clear();
// disconnect the signal
disconnect(p.data(), SIGNAL(voidSignal()), &QTestEventLoop::instance(), 0);
// emit the signal again:
emit targetObj.voidSignal();
QTestEventLoop::instance().enterLoop(2);
QVERIFY(!QTestEventLoop::instance().timeout());
// and now it mustn't have been received
QVERIFY(s.isEmpty());
// cleanup: // cleanup:
con.interface()->unregisterService(serviceToFollow); con.interface()->unregisterService(serviceToFollow);