From 6c0c327e68a12741c9e2e68bb2ce2f6b5c881b82 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 28 May 2025 09:29:05 +0200 Subject: [PATCH] QXdgDesktopPortalTheme: normalize SLOT argument Non-normalized signatures passed to SIGNAL or SLOT macros require a normalization step before the actual connection can be made, which takes extra time and extra memory. Also, a normalized signature is generally smaller than a non-normalized one, so we save even in executable code size. Amends a833d5682ac44571e13568336f2bd3ec7deb1d6d. Task-number: QTBUG-116197 Pick-to: 6.8 Change-Id: I942f5ac262f05ca4486b2ed2a22654d1a12a3ef0 Reviewed-by: Fabian Kosmale (cherry picked from commit 71842cfb89da0bed1efd6cf7a567550d9e8119f6) Reviewed-by: Qt Cherry-pick Bot --- .../platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp index 2b3fb2b9494..06ac4b2ee02 100644 --- a/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp +++ b/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportaltheme.cpp @@ -137,7 +137,7 @@ QXdgDesktopPortalTheme::QXdgDesktopPortalTheme() QDBusConnection::sessionBus().connect( "org.freedesktop.portal.Desktop"_L1, "/org/freedesktop/portal/desktop"_L1, "org.freedesktop.portal.Settings"_L1, "SettingChanged"_L1, d_ptr.get(), - SLOT(settingChanged(QString, QString, QDBusVariant))); + SLOT(settingChanged(QString,QString,QDBusVariant))); } QPlatformMenuItem* QXdgDesktopPortalTheme::createPlatformMenuItem() const