1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused members

Browse Source 
Clang found two problems with this from QWaylandDataDeviceManager. First,
it's a class, not a struct.  Second, nothing is using this private
member.

qwaylanddatadevicemanager_p.h:66:5: warning: struct 'wl_data_device_manager' was previously declared as a class [-Wmismatched-tags]
qwaylanddatadevicemanager_p.h:66:36: warning: private field 'm_data_device_manager' is not used [-Wunused-private-field]

And also this one:

qwaylandextendedoutput_p.h:61:21: warning: private field 'm_screen' is not used [-Wunused-private-field]

Change-Id: Ifc8f28f92190547dcb0a5319aa6fc14277894f15
Reviewed-by: Giulio Camuffo <giulio.camuffo@jollamobile.com>
This commit is contained in:
Thiago Macieira 2014-11-23 07:15:35 -08:00
parent d2e278e4e2
commit 68a6cf54a0
3 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/platforms/wayland/qwaylanddatadevicemanager_p.h
View File

@ -63,7 +63,6 @@ public:
QWaylandDisplay *display() const; QWaylandDisplay *display() const;
private: private:
struct wl_data_device_manager *m_data_device_manager;
QWaylandDisplay *m_display; QWaylandDisplay *m_display;
}; };

2
src/plugins/platforms/wayland/qwaylandextendedoutput.cpp
View File

@ -51,8 +51,8 @@ QT_BEGIN_NAMESPACE
QWaylandExtendedOutput::QWaylandExtendedOutput(QWaylandScreen *screen, ::qt_extended_output *extended_output) QWaylandExtendedOutput::QWaylandExtendedOutput(QWaylandScreen *screen, ::qt_extended_output *extended_output)
: QtWayland::qt_extended_output(extended_output) : QtWayland::qt_extended_output(extended_output)
, m_screen(screen)
{ {
Q_UNUSED(screen);
} }
QT_END_NAMESPACE QT_END_NAMESPACE

4
src/plugins/platforms/wayland/qwaylandextendedoutput_p.h
View File

@ -55,10 +55,6 @@ class Q_WAYLAND_CLIENT_EXPORT QWaylandExtendedOutput : public QtWayland::qt_exte
{ {
public: public:
QWaylandExtendedOutput(QWaylandScreen *screen, struct ::qt_extended_output *extended_output); QWaylandExtendedOutput(QWaylandScreen *screen, struct ::qt_extended_output *extended_output);
private:
QWaylandScreen *m_screen;
}; };
QT_END_NAMESPACE QT_END_NAMESPACE