1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QPostEventList: use qsizetype to count posted events

Browse Source 
It's highly unlikely you're going to have more than 2 billion pending
events for a thread, but this is the right thing to do.

Pick-to: 6.8
Change-Id: Ia162b024815c3b970d71fffd3bc022621b2e07b4
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
This commit is contained in:
Thiago Macieira 2024-11-13 11:44:57 -08:00
parent 363f069b0b
commit 67a71d7109
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/corelib/kernel/qobject.cpp
View File

@ -1751,8 +1751,8 @@ void QObjectPrivate::setThreadData_helper(QThreadData *currentData, QThreadData
} }
// move posted events // move posted events
int eventsMoved = 0; qsizetype eventsMoved = 0;
for (int i = 0; i < currentData->postEventList.size(); ++i) { for (qsizetype i = 0; i < currentData->postEventList.size(); ++i) {
const QPostEvent &pe = currentData->postEventList.at(i); const QPostEvent &pe = currentData->postEventList.at(i);
if (!pe.event) if (!pe.event)
continue; continue;

2
src/corelib/thread/qthread.cpp
View File

@ -73,7 +73,7 @@ QThreadData::~QThreadData()
thread.storeRelease(nullptr); thread.storeRelease(nullptr);
delete t; delete t;
for (int i = 0; i < postEventList.size(); ++i) { for (qsizetype i = 0; i < postEventList.size(); ++i) {
const QPostEvent &pe = postEventList.at(i); const QPostEvent &pe = postEventList.at(i);
if (pe.event) { if (pe.event) {
--pe.receiver->d_func()->postedEvents; --pe.receiver->d_func()->postedEvents;