1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark QHttpNetworkConnectionChannel as final

Browse Source 
To suppress clang-tidy's
bugprone-pointer-arithmetic-on-polymorphic-object
because we store a dynamically allocated array of
QHttpNetworkConnectionChannel objects in QHttpNetworkConnectionPrivate
and index into this all over the code.

Pick-to: 6.8
Change-Id: Ibcdf7c8acc4a57eaf36bca3719733655053ac818
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Mate Barany <mate.barany@qt.io>
(cherry picked from commit 930dfd11dd7d8a0135c5d80d047b95bb8a55cbcd)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Mårten Nordheim 2025-02-17 15:55:24 +01:00 committed by Qt Cherry-pick Bot
parent 3b8f6bb3d6
commit 657ccdab53
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/access/qhttpnetworkconnectionchannel_p.h
View File

@ -62,7 +62,7 @@ class QByteArray;
typedef std::pair<QHttpNetworkRequest, QHttpNetworkReply*> HttpMessagePair; typedef std::pair<QHttpNetworkRequest, QHttpNetworkReply*> HttpMessagePair;
#endif #endif
class QHttpNetworkConnectionChannel : public QObject { class QHttpNetworkConnectionChannel final : public QObject {
Q_OBJECT Q_OBJECT
public: public:
// TODO: Refactor this to add an EncryptingState (and remove pendingEncrypt). // TODO: Refactor this to add an EncryptingState (and remove pendingEncrypt).