1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CommonStyle/QSlider: use drawLines() instead single drawLine() calls

Browse Source 
Optimize the painting of the tickmarks by collecting all lines to draw
in a vector and then passing all to the painter instead calling
drawLine() for every single tickmark.

Change-Id: Ic75e733a02fbf6143d21d4630f6a6d6de913f16c
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit 83ab7d21150115fbbe954af7d87f1597bf65d206)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Christian Ehrlicher 2023-12-29 15:27:46 +01:00 committed by Qt Cherry-pick Bot
parent 5278624b62
commit 656576d3b4
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/widgets/styles/qfusionstyle.cpp
View File

@ -2785,6 +2785,7 @@ void QFusionStyle::drawComplexControl(ComplexControl control, const QStyleOption
int v = slider->minimum; int v = slider->minimum;
int len = proxy()->pixelMetric(PM_SliderLength, slider, widget); int len = proxy()->pixelMetric(PM_SliderLength, slider, widget);
QVector<QLine> lines;
while (v <= slider->maximum + 1) { while (v <= slider->maximum + 1) {
if (v == slider->maximum + 1 && interval == 1) if (v == slider->maximum + 1 && interval == 1)
break; break;
@ -2798,21 +2799,21 @@ void QFusionStyle::drawComplexControl(ComplexControl control, const QStyleOption
if (horizontal) { if (horizontal) {
if (ticksAbove) { if (ticksAbove) {
painter->drawLine(pos, slider->rect.top() + extra, lines += QLine(pos, slider->rect.top() + extra,
pos, slider->rect.top() + tickSize); pos, slider->rect.top() + tickSize);
} }
if (ticksBelow) { if (ticksBelow) {
painter->drawLine(pos, slider->rect.bottom() - extra, lines += QLine(pos, slider->rect.bottom() - extra,
pos, slider->rect.bottom() - tickSize); pos, slider->rect.bottom() - tickSize);
} }
} else { } else {
if (ticksAbove) { if (ticksAbove) {
painter->drawLine(slider->rect.left() + extra, pos, lines += QLine(slider->rect.left() + extra, pos,
slider->rect.left() + tickSize, pos); slider->rect.left() + tickSize, pos);
} }
if (ticksBelow) { if (ticksBelow) {
painter->drawLine(slider->rect.right() - extra, pos, lines += QLine(slider->rect.right() - extra, pos,
slider->rect.right() - tickSize, pos); slider->rect.right() - tickSize, pos);
} }
} }
// in the case where maximum is max int // in the case where maximum is max int
@ -2821,6 +2822,7 @@ void QFusionStyle::drawComplexControl(ComplexControl control, const QStyleOption
break; break;
v = nextInterval; v = nextInterval;
} }
painter->drawLines(lines);
} }
// draw handle // draw handle
if ((option->subControls & SC_SliderHandle) ) { if ((option->subControls & SC_SliderHandle) ) {