From 655fdae1235476b43fb9d5bd43d12853ed7008c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Thu, 23 Feb 2023 15:15:46 +0100 Subject: [PATCH] QtConcurrent: yield CPU when spinning on atomics Change-Id: I3eef19d8737da60bee40385a64a1bc136d2e7329 Reviewed-by: Thiago Macieira (cherry picked from commit ee1651efdd32dfb96443828ddaeddccb3e4e3648) Reviewed-by: Qt Cherry-pick Bot --- src/concurrent/qtconcurrentthreadengine.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/concurrent/qtconcurrentthreadengine.cpp b/src/concurrent/qtconcurrentthreadengine.cpp index d10cca5de70..03e018b0a29 100644 --- a/src/concurrent/qtconcurrentthreadengine.cpp +++ b/src/concurrent/qtconcurrentthreadengine.cpp @@ -3,6 +3,8 @@ #include "qtconcurrentthreadengine.h" +#include + #if !defined(QT_NO_CONCURRENT) || defined(Q_QDOC) QT_BEGIN_NAMESPACE @@ -63,6 +65,7 @@ void ThreadEngineBarrier::acquire() if (count.testAndSetOrdered(localCount, localCount + 1)) return; } + qYieldCpu(); } } @@ -82,6 +85,7 @@ int ThreadEngineBarrier::release() if (count.testAndSetOrdered(localCount, localCount - 1)) return localCount - 1; } + qYieldCpu(); } } @@ -98,6 +102,7 @@ void ThreadEngineBarrier::wait() semaphore.acquire(); return; } + qYieldCpu(); } } @@ -121,6 +126,7 @@ bool ThreadEngineBarrier::releaseUnlessLast() if (count.testAndSetOrdered(localCount, localCount - 1)) return true; } + qYieldCpu(); } }