1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

a11y: fix race condition on atspi startup on Wayland

Browse Source 
This amends db346e711c9af50566c234cfc21199680e6cb499 .

Previously we could race between dbus connecting and our "manual"
enabled call since we didn't take into account whether dbus is
connected or not.

This lead to scenarios where opening an application (in particular under
Wayland) would result in the application not being able to register on
the a11y bus because registration was attempted too early.
By simply taking connectedness into account we'll make sure to not
run registration too early anymore.

Change-Id: I46a3c0b57f8a0c83d3e5fae9e355c2061954031f
Reviewed-by: Liang Qi <liang.qi@qt.io>
(cherry picked from commit 918fed39156c90540a12557c7a6630ae3d7d841e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 197e5915585e8978e8b98a861f71f2d22b0d930e)
This commit is contained in:
Harald Sitter 2023-08-01 13:56:24 +02:00 committed by Qt Cherry-pick Bot
parent dc0313146a
commit 63cebc00fb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gui/accessible/linux/qspiaccessiblebridge.cpp
View File

@ -38,7 +38,7 @@ QSpiAccessibleBridge::QSpiAccessibleBridge()
// But do that only on next loop, once dbus is really settled.
QTimer::singleShot(
0, this, [this]{
if (dbusConnection->isEnabled())
if (dbusConnection->isEnabled() && dbusConnection->connection().isConnected())
enabledChanged(true);
});
}