From 6333376402eeaa14deb0954e863392b606aad3b2 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Tue, 4 Jun 2024 22:33:44 +0200 Subject: [PATCH] QAbstractItemModelTester: Check size hint role Returning the wrong data type for Qt::SizeHintRole may lead to a size of 0,0 and the item disappearing. Task-number: PYSIDE-2772 Change-Id: I906445f2ed2141da2606774f2b8ad6282662eb17 Reviewed-by: hjk (cherry picked from commit 84f2cd6523081ed8774b2a9fe9ee36d05172ff50) Reviewed-by: Qt Cherry-pick Bot --- src/testlib/qabstractitemmodeltester.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/testlib/qabstractitemmodeltester.cpp b/src/testlib/qabstractitemmodeltester.cpp index eb52d28d59d..ddcf328843c 100644 --- a/src/testlib/qabstractitemmodeltester.cpp +++ b/src/testlib/qabstractitemmodeltester.cpp @@ -669,6 +669,10 @@ void QAbstractItemModelTesterPrivate::data() || state == Qt::Checked); } + QVariant sizeHintVariant = model->data(model->index(0, 0), Qt::SizeHintRole); + if (sizeHintVariant.isValid()) + MODELTESTER_VERIFY(sizeHintVariant.canConvert()); + Q_Q(QAbstractItemModelTester); if (!QTestPrivate::testDataGuiRoles(q))