From 5f69c44d750846ddcb10630f7cea8f6f828366c2 Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Wed, 11 Jun 2025 09:53:52 +0200 Subject: [PATCH] QNetworkAccessBackend: Do not leak wrapped upload byte device MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The wrappedUploadByteDevice is obviously intended to be owned by QNetworkAccessBackend. It needs to be deleted when QNetworkAccessBackend is destroyed. Ideally we shouldn't use bare pointers at all here, but since we need to pick this back all the way to 6.5, a minimal fix is preferred. Amends commit bba0bdb35c2806bcdde8e89965e99b3d412b8d3a Change-Id: Icbe857ad02c23693c313d3fcb2d0ee068362e5b7 Pick-to: 6.8 6.5 Reviewed-by: Marc Mutz Reviewed-by: Mårten Nordheim (cherry picked from commit 9a7d06f0d4551ef393eab6da21ad162582dccda6) Reviewed-by: Qt Cherry-pick Bot (cherry picked from commit ce0e4ca6fe5ec21275c3884216800521fc6280f5) --- src/network/access/qnetworkaccessbackend.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/network/access/qnetworkaccessbackend.cpp b/src/network/access/qnetworkaccessbackend.cpp index 7fc0b474bb5..7ba97447657 100644 --- a/src/network/access/qnetworkaccessbackend.cpp +++ b/src/network/access/qnetworkaccessbackend.cpp @@ -258,7 +258,10 @@ QNetworkAccessBackend::QNetworkAccessBackend(TargetTypes targetTypes, IOFeatures /*! Destructs the QNetworkAccessBackend base class. */ -QNetworkAccessBackend::~QNetworkAccessBackend() { } +QNetworkAccessBackend::~QNetworkAccessBackend() +{ + delete d_func()->wrappedUploadByteDevice; +} /*! Returns the security related features that the backend claims to