1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HTTP internals: fix QHttpNetworkRequestPrivate::operator==

Browse Source 
We were not comparing all fields.

Spotted-by: Richard J. Moore <rich@kde.org>

Change-Id: I5c1a773b00b64a26606c47ced292808696c9b4bb
Reviewed-by: Richard J. Moore <rich@kde.org>
This commit is contained in:
Peter Hartmann 2013-06-14 14:30:52 +02:00 committed by The Qt Project
parent 48345e5d3c
commit 5defb3a36a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/access/qhttpnetworkrequest.cpp
View File

@ -76,8 +76,14 @@ bool QHttpNetworkRequestPrivate::operator==(const QHttpNetworkRequestPrivate &ot
{ {
return QHttpNetworkHeaderPrivate::operator==(other) return QHttpNetworkHeaderPrivate::operator==(other)
&& (operation == other.operation) && (operation == other.operation)
&& (ssl == other.ssl) && (priority == other.priority)
&& (uploadByteDevice == other.uploadByteDevice) && (uploadByteDevice == other.uploadByteDevice)
&& (autoDecompress == other.autoDecompress)
&& (pipeliningAllowed == other.pipeliningAllowed)
// we do not clear the customVerb in setOperation
&& (operation != QHttpNetworkRequest::Custom || (customVerb == other.customVerb))
&& (withCredentials == other.withCredentials)
&& (ssl == other.ssl)
&& (preConnect == other.preConnect); && (preConnect == other.preConnect);
} }