1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove wait calls in tst_QProcess::simpleStart

Browse Source 
Instead of calling different wait functions on different platforms,
we use QTRY_COMPARE to check the process state.

Change-Id: I6489cabce9e63f9c8b1036f3cccbf35b52df72e7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Andreas Holzammer <andreas.holzammer@kdab.com>
This commit is contained in:
Joerg Bornemann 2013-07-01 10:54:35 +02:00 committed by The Qt Project
parent e8c3316ab0
commit 5cfac290ca
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/auto/corelib/io/qprocess/tst_qprocess.cpp
View File

@ -267,15 +267,7 @@ void tst_QProcess::simpleStart()
QCOMPARE(process->state(), QProcess::Running);
QVERIFY2(process->waitForStarted(5000), qPrintable(process->errorString()));
QCOMPARE(process->state(), QProcess::Running);
#if defined(Q_OS_WINCE)
// Note: This actually seems incorrect, it will only exit the while loop when finishing fails
while (process->waitForFinished(5000))
{ }
#else
while (process->waitForReadyRead(5000))
{ }
#endif
QCOMPARE(int(process->state()), int(QProcess::NotRunning));
QTRY_COMPARE(process->state(), QProcess::NotRunning);
delete process;
process = 0;