From 5bae58bb454fee8aee2eed61d587b66ff12cec99 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 7 Aug 2023 21:24:42 +0200 Subject: [PATCH] tst_macdeployqt: fix runVerifyDeployment() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit QList rather pointlessly has a startsWith() function, which means this code compiled. But the code makes no sense: it tests the same condition over and over again, so I'm assuming that it should be path.startsWith() and not path_s_.startsWith(). Amends 3f56950862181f4d50f30d66f577c933795522c3, but that just imported the code from qttools. I didn't check whether the bug was present there, already. Change-Id: I98a4bbfe0400700655a5c2137f7a976a835a8d28 Reviewed-by: Qt CI Bot Reviewed-by: Tor Arne Vestbø (cherry picked from commit 52ef958429cf09a46f71d0165bb4150c61f76ebc) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/tools/macdeployqt/tst_macdeployqt.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp b/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp index 40a142c96d4..95608541978 100644 --- a/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp +++ b/tests/auto/tools/macdeployqt/tst_macdeployqt.cpp @@ -203,7 +203,7 @@ void runVerifyDeployment(const QString &name) part = part.trimmed(); if (part.isEmpty()) continue; - QVERIFY(!parts.startsWith(qtPath)); + QVERIFY(!part.startsWith(qtPath)); } }