From 5b10a1e8b4137cd8031f100039c39a1cc93f5d4e Mon Sep 17 00:00:00 2001
From: Thiago Macieira <thiago.macieira@intel.com>
Date: Tue, 11 Feb 2025 08:38:50 -0800
Subject: [PATCH] tst_QByteArrayView: stop using std::basic_string<signed char>

That's not a valid type for the Standard's string, because the Standard
doesn't allow for std::char_traits<signed char> either.

Pick-to: 6.8
Fixes: QTBUG-133689
Change-Id: Icd0d4928fa4cdc9d806bfffd4053f0eb1073e6b4
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit 0cc41083c30c1474a862a34b59a4f755d4c51640)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 .../auto/corelib/text/qbytearrayview/tst_qbytearrayview.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/auto/corelib/text/qbytearrayview/tst_qbytearrayview.cpp b/tests/auto/corelib/text/qbytearrayview/tst_qbytearrayview.cpp
index 0155a1aeb9e..c951b70a5b7 100644
--- a/tests/auto/corelib/text/qbytearrayview/tst_qbytearrayview.cpp
+++ b/tests/auto/corelib/text/qbytearrayview/tst_qbytearrayview.cpp
@@ -721,7 +721,11 @@ void tst_QByteArrayView::fromContainers() const
     fromContainer<Char, QVector<Char>>();
     fromContainer<Char, QVarLengthArray<Char>>();
     fromContainer<Char, std::vector<Char>>();
-    fromContainer<Char, std::basic_string<Char>>();
+    if constexpr (std::is_same_v<Char, char>) {
+        // std::basic_string only supports a few specific types
+        // (std::char_traits requirement)
+        fromContainer<Char, std::basic_string<Char>>();
+    }
 }
 
 void tst_QByteArrayView::comparison() const