1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QObject: do not copy a ConnectionList object

Browse Source 
The semantics of copying a ConnectionList are not defined; the type
is copiable by accident. Use a reference to the list instead (like done
in other places in the code).

Change-Id: Ifbc5d3baca992f3eb13e3781378e79ed1feb4e1c
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Giuseppe D'Angelo 2023-09-13 10:34:30 +02:00
parent e49d8444dc
commit 5ac97a38e8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/kernel/qobject.cpp
View File

@ -5455,7 +5455,7 @@ QObjectPrivate::getPropertyAdaptorSlotObject(const QMetaProperty &property)
int signal_index = methodIndexToSignalIndex(&metaObject, property.notifySignalIndex()); int signal_index = methodIndexToSignalIndex(&metaObject, property.notifySignalIndex());
if (signal_index >= conns->signalVectorCount()) if (signal_index >= conns->signalVectorCount())
return nullptr; return nullptr;
const auto connectionList = conns->connectionsForSignal(signal_index); const auto &connectionList = conns->connectionsForSignal(signal_index);
for (auto c = connectionList.first.loadRelaxed(); c; for (auto c = connectionList.first.loadRelaxed(); c;
c = c->nextConnectionList.loadRelaxed()) { c = c->nextConnectionList.loadRelaxed()) {
if (c->isSlotObject) { if (c->isSlotObject) {