From 5a911f72c658ea7e6a65a7cedf9ed99af3c4c3c3 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Wed, 9 Apr 2025 17:25:39 +0200 Subject: [PATCH] Check status of QDataStream in QTimeZone tests using it It makes sense to verify the stream is OK after writing and reading, so add those tests. Change-Id: I459856ed0d991bc3bbe4044b6694c97970cf2787 Reviewed-by: Thiago Macieira --- tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp b/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp index f144838b163..c87ad9bc038 100644 --- a/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp +++ b/tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp @@ -493,11 +493,13 @@ void tst_QTimeZone::dataStreamTest() { QDataStream ds(&tmp, QIODevice::WriteOnly); ds << tz1; + QCOMPARE(ds.status(), QDataStream::Ok); } QTimeZone tz2("UTC-12:00"); // Shall be over-written. { QDataStream ds(&tmp, QIODevice::ReadOnly); ds >> tz2; + QCOMPARE(ds.status(), QDataStream::Ok); } QCOMPARE(tz2.id(), "QST"_ba); QCOMPARE(tz2.comment(), u"Qt Testing"_s); @@ -515,10 +517,12 @@ void tst_QTimeZone::dataStreamTest() { QDataStream ds(&tmp, QIODevice::WriteOnly); ds << tz1; + QCOMPARE(ds.status(), QDataStream::Ok); } { QDataStream ds(&tmp, QIODevice::ReadOnly); ds >> tz2; + QCOMPARE(ds.status(), QDataStream::Ok); } QCOMPARE(tz2.isValid(), true); QCOMPARE(tz2.id(), tz1.id()); @@ -533,11 +537,13 @@ void tst_QTimeZone::dataStreamTest() { QDataStream ds(&tmp, QIODevice::WriteOnly); ds << tz1; + QCOMPARE(ds.status(), QDataStream::Ok); } tz2 = QTimeZone("UTC"); { QDataStream ds(&tmp, QIODevice::ReadOnly); ds >> tz2; + QCOMPARE(ds.status(), QDataStream::Ok); } QCOMPARE(tz2.id(), tz1.id()); #endif