From 59a740e9973b77bf3bb86f4e96efd46277455782 Mon Sep 17 00:00:00 2001 From: Alexey Edelev Date: Thu, 8 Jun 2023 12:30:07 +0200 Subject: [PATCH] Replace list(FIND with simplified IN_LIST check Pick-to: 6.6 6.5 Change-Id: I2ed1803adabc36e646edae3b2bb07e5ff2194d9b Reviewed-by: Amir Masoud Abdol Reviewed-by: Qt CI Bot --- cmake/QtFlagHandlingHelpers.cmake | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cmake/QtFlagHandlingHelpers.cmake b/cmake/QtFlagHandlingHelpers.cmake index 140c57053e4..57743067af8 100644 --- a/cmake/QtFlagHandlingHelpers.cmake +++ b/cmake/QtFlagHandlingHelpers.cmake @@ -117,8 +117,7 @@ endfunction() function(qt_internal_apply_gc_binaries target visibility) set(possible_visibilities PRIVATE INTERFACE PUBLIC) - list(FIND possible_visibilities "${visibility}" known_visibility) - if (known_visibility EQUAL "-1") + if(NOT visibility IN_LIST possible_visibilities) message(FATAL_ERROR "Visibitily setting must be one of PRIVATE, INTERFACE or PUBLIC.") endif() @@ -149,8 +148,7 @@ function(qt_internal_apply_intel_cet target visibility) endif() set(possible_visibilities PRIVATE INTERFACE PUBLIC) - list(FIND possible_visibilities "${visibility}" known_visibility) - if (known_visibility EQUAL "-1") + if(NOT visibility IN_LIST possible_visibilities) message(FATAL_ERROR "Visibitily setting must be one of PRIVATE, INTERFACE or PUBLIC.") endif()