1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QProcess: Remove dead code

Browse Source 
These functions appear to have been dead code always - even in the
earliest Qt4 releases!

Change-Id: Ie2a458092b45113782284cf8ed3aa11a018b60d4
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Louai Al-Khanji 2016-02-04 17:46:50 -08:00
parent 3b73ee0fb5
commit 58bd015ddf
4 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/corelib/io/qprocess_p.h
View File

@ -381,7 +381,6 @@ public:
bool waitForReadyRead(int msecs = 30000);
bool waitForBytesWritten(int msecs = 30000);
bool waitForFinished(int msecs = 30000);
bool waitForWrite(int msecs = 30000);
qint64 bytesAvailableInChannel(const Channel *channel) const;
qint64 readFromChannel(const Channel *channel, char *data, qint64 maxlen);

6
src/corelib/io/qprocess_unix.cpp
View File

@ -1034,12 +1034,6 @@ bool QProcessPrivate::waitForFinished(int msecs)
return false;
}
bool QProcessPrivate::waitForWrite(int msecs)
{
pollfd pfd = qt_make_pollfd(stdinChannel.pipe[1], POLLOUT);
return qt_poll_msecs(&pfd, 1, msecs < 0 ? 0 : msecs) == 1;
}
void QProcessPrivate::findExitCode()
{
}

9
src/corelib/io/qprocess_win.cpp
View File

@ -819,15 +819,6 @@ qint64 QProcessPrivate::writeToStdin(const char *data, qint64 maxlen)
return stdinChannel.writer->write(data, maxlen);
}
bool QProcessPrivate::waitForWrite(int msecs)
{
if (!stdinChannel.writer || stdinChannel.writer->waitForWrite(msecs))
return true;
setError(QProcess::Timedout);
return false;
}
bool QProcessPrivate::startDetached(const QString &program, const QStringList &arguments, const QString &workingDir, qint64 *pid)
{
QString args = qt_create_commandline(program, arguments);

6
src/corelib/io/qprocess_wince.cpp
View File

@ -278,12 +278,6 @@ qint64 QProcessPrivate::writeToStdin(const char *data, qint64 maxlen)
return -1;
}
bool QProcessPrivate::waitForWrite(int msecs)
{
Q_UNUSED(msecs);
return false;
}
bool QProcessPrivate::startDetached(const QString &program, const QStringList &arguments, const QString &workingDir, qint64 *pid)
{
Q_UNUSED(workingDir);