1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qguiapplication.cpp / init_platform() - optimize ranged loop and style

Browse Source 
Use std::as_const() for a QStringList in a ranged for-loop.
Use auto * for a pointer.

Pick-to: 6.8 6.5
Fixes: QTBUG-134702
Change-Id: Ia092933fe959afdd6b6e0a9743e3603c29b291d8
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Liang Qi <liang.qi@qt.io>
(cherry picked from commit 22e05d74b2d01cc49c2893f66824d6e229558320)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Axel Spoerl 2025-03-18 08:29:47 +01:00 committed by Qt Cherry-pick Bot
parent f39b02ed4b
commit 56db6d25a4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gui/kernel/qguiapplication.cpp
View File

@ -1291,7 +1291,7 @@ static void init_platform(const QString &pluginNamesWithArguments, const QString
QStringList plugins = pluginNamesWithArguments.split(u';', Qt::SkipEmptyParts); QStringList plugins = pluginNamesWithArguments.split(u';', Qt::SkipEmptyParts);
QStringList platformArguments; QStringList platformArguments;
QStringList availablePlugins = QPlatformIntegrationFactory::keys(platformPluginPath); QStringList availablePlugins = QPlatformIntegrationFactory::keys(platformPluginPath);
for (const auto &pluginArgument : plugins) { for (const auto &pluginArgument : std::as_const(plugins)) {
// Split into platform name and arguments // Split into platform name and arguments
QStringList arguments = pluginArgument.split(u':', Qt::SkipEmptyParts); QStringList arguments = pluginArgument.split(u':', Qt::SkipEmptyParts);
if (arguments.isEmpty()) if (arguments.isEmpty())
@ -1411,7 +1411,7 @@ static void init_platform(const QString &pluginNamesWithArguments, const QString
} }
} }
const auto platformIntegration = QGuiApplicationPrivate::platformIntegration(); const auto *platformIntegration = QGuiApplicationPrivate::platformIntegration();
fontSmoothingGamma = platformIntegration->styleHint(QPlatformIntegration::FontSmoothingGamma).toReal(); fontSmoothingGamma = platformIntegration->styleHint(QPlatformIntegration::FontSmoothingGamma).toReal();
QCoreApplication::setAttribute(Qt::AA_DontShowShortcutsInContextMenus, QCoreApplication::setAttribute(Qt::AA_DontShowShortcutsInContextMenus,
!QGuiApplication::styleHints()->showShortcutsInContextMenus()); !QGuiApplication::styleHints()->showShortcutsInContextMenus());