From 55765898fe7eb467b5675709ee765c24d71df7d6 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Wed, 19 May 2021 16:39:29 +0200 Subject: [PATCH] Initialize SYSTEMTIME to {} instead of memset()ing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Ic17b90d10d6b5b7f4610e904e18979fc1d658a0a Reviewed-by: Qt CI Bot Reviewed-by: MÃ¥rten Nordheim Reviewed-by: Thiago Macieira --- src/corelib/time/qdatetime.cpp | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/corelib/time/qdatetime.cpp b/src/corelib/time/qdatetime.cpp index ca79ce4badb..6e2476c5aac 100644 --- a/src/corelib/time/qdatetime.cpp +++ b/src/corelib/time/qdatetime.cpp @@ -4669,8 +4669,7 @@ static inline uint msecsFromDecomposed(int hour, int minute, int sec, int msec = QDate QDate::currentDate() { - SYSTEMTIME st; - memset(&st, 0, sizeof(SYSTEMTIME)); + SYSTEMTIME st = {}; GetLocalTime(&st); return QDate(st.wYear, st.wMonth, st.wDay); } @@ -4678,8 +4677,7 @@ QDate QDate::currentDate() QTime QTime::currentTime() { QTime ct; - SYSTEMTIME st; - memset(&st, 0, sizeof(SYSTEMTIME)); + SYSTEMTIME st = {}; GetLocalTime(&st); ct.setHMS(st.wHour, st.wMinute, st.wSecond, st.wMilliseconds); return ct; @@ -4688,8 +4686,7 @@ QTime QTime::currentTime() QDateTime QDateTime::currentDateTime() { QTime t; - SYSTEMTIME st; - memset(&st, 0, sizeof(SYSTEMTIME)); + SYSTEMTIME st = {}; GetLocalTime(&st); QDate d(st.wYear, st.wMonth, st.wDay); t.mds = msecsFromDecomposed(st.wHour, st.wMinute, st.wSecond, st.wMilliseconds); @@ -4699,8 +4696,7 @@ QDateTime QDateTime::currentDateTime() QDateTime QDateTime::currentDateTimeUtc() { QTime t; - SYSTEMTIME st; - memset(&st, 0, sizeof(SYSTEMTIME)); + SYSTEMTIME st = {}; GetSystemTime(&st); QDate d(st.wYear, st.wMonth, st.wDay); t.mds = msecsFromDecomposed(st.wHour, st.wMinute, st.wSecond, st.wMilliseconds); @@ -4709,8 +4705,7 @@ QDateTime QDateTime::currentDateTimeUtc() qint64 QDateTime::currentMSecsSinceEpoch() noexcept { - SYSTEMTIME st; - memset(&st, 0, sizeof(SYSTEMTIME)); + SYSTEMTIME st = {}; GetSystemTime(&st); const qint64 daysAfterEpoch = QDate(1970, 1, 1).daysTo(QDate(st.wYear, st.wMonth, st.wDay)); @@ -4720,8 +4715,7 @@ qint64 QDateTime::currentMSecsSinceEpoch() noexcept qint64 QDateTime::currentSecsSinceEpoch() noexcept { - SYSTEMTIME st; - memset(&st, 0, sizeof(SYSTEMTIME)); + SYSTEMTIME st = {}; GetSystemTime(&st); const qint64 daysAfterEpoch = QDate(1970, 1, 1).daysTo(QDate(st.wYear, st.wMonth, st.wDay));