From 55148eb94d314187986492214415e0f0472bbb26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Morten=20S=C3=B8rvig?= Date: Mon, 27 Jan 2025 13:06:41 +0100 Subject: [PATCH] wasm: don't give native focus to non-focus windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit isActive() may return true if a (transient) parent window is active (has focus). Compare against QGuiApplication::focusWindow() instead. Fixes: QTBUG-129233 Pick-to: 6.8 Change-Id: I834a5814a5db161bdea2ba3524d1010e0c0e3e6e Reviewed-by: Even Oscar Andersen Reviewed-by: Piotr WierciƄski Reviewed-by: Lorn Potter (cherry picked from commit 31762e2e704673057a292ac59977b501919f2450) Reviewed-by: Qt Cherry-pick Bot --- src/plugins/platforms/wasm/qwasmwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/platforms/wasm/qwasmwindow.cpp b/src/plugins/platforms/wasm/qwasmwindow.cpp index e0925a08461..582788a3412 100644 --- a/src/plugins/platforms/wasm/qwasmwindow.cpp +++ b/src/plugins/platforms/wasm/qwasmwindow.cpp @@ -314,7 +314,7 @@ void QWasmWindow::setVisible(bool visible) m_compositor->requestUpdateWindow(this, QRect(QPoint(0, 0), geometry().size()), QWasmCompositor::ExposeEventDelivery); m_decoratedWindow["style"].set("display", visible ? "block" : "none"); - if (window()->isActive()) + if (window() == QGuiApplication::focusWindow()) m_canvas.call("focus"); if (visible) applyWindowState();