1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor code cleanup QTestPrivate::parseBlackList()

Browse Source 
Constify local variables, where possible.
Remove redundant include.
Bump (c) year to 2024.

Change-Id: If13fb87b306926cb94f75186071a1dff2969a945
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 6de2203fb75e034c1a02478daa13e8ddfcea5d75)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Axel Spoerl 2024-07-23 08:36:15 +02:00 committed by Qt Cherry-pick Bot
parent d04e4bac4f
commit 5413d4b460
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/testlib/qtestblacklist.cpp
View File

@ -1,8 +1,6 @@
// Copyright (C) 2022 The Qt Company Ltd. // Copyright (C) 2024 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
#include "qtestblacklist_p.h" #include "qtestblacklist_p.h"
#include "qtestresult_p.h"
#include <QtTest/qtestcase.h> #include <QtTest/qtestcase.h>
#include <QtCore/qbytearray.h> #include <QtCore/qbytearray.h>
#include <QtCore/qfile.h> #include <QtCore/qfile.h>
@ -246,7 +244,7 @@ namespace QTestPrivate {
void parseBlackList() void parseBlackList()
{ {
QString filename = QTest::qFindTestData(QStringLiteral("BLACKLIST")); const QString filename = QTest::qFindTestData(QStringLiteral("BLACKLIST"));
if (filename.isEmpty()) if (filename.isEmpty())
return; return;
QFile ignored(filename); QFile ignored(filename);
@ -267,7 +265,7 @@ void parseBlackList()
function = line.mid(1, line.size() - 2); function = line.mid(1, line.size() - 2);
continue; continue;
} }
bool condition = checkCondition(line); const bool condition = checkCondition(line);
if (condition) { if (condition) {
if (!function.size()) { if (!function.size()) {
ignoreAll = true; ignoreAll = true;