1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

permit returning from files

Browse Source 
this allows skipping an entire feature file if a condition is not
fulfilled, without putting the whole body inside a conditional.

Change-Id: I84fe9c94dda58c794fb52c3f163b40563b0db30a
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
This commit is contained in:
Oswald Buddenhagen 2013-03-05 12:35:05 +01:00 committed by The Qt Project
parent 0dedf8c340
commit 525eb33767
1 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
qmake/library/qmakeparser.cpp
View File

@ -1024,7 +1024,6 @@ void QMakeParser::finalizeCall(ushort *&tokPtr, ushort *uc, ushort *ptr, int arg
m_tmp.setRawData((QChar *)uc + 4, nlen); m_tmp.setRawData((QChar *)uc + 4, nlen);
const QString *defName; const QString *defName;
ushort defType; ushort defType;
uchar nest;
if (m_tmp == statics.strfor) { if (m_tmp == statics.strfor) {
if (m_invert || m_operator == OrOperator) { if (m_invert || m_operator == OrOperator) {
// '|' could actually work reasonably, but qmake does nonsense here. // '|' could actually work reasonably, but qmake does nonsense here.
@ -1101,13 +1100,20 @@ void QMakeParser::finalizeCall(ushort *&tokPtr, ushort *uc, ushort *ptr, int arg
parseError(fL1S("%1(function) requires one literal argument.").arg(*defName)); parseError(fL1S("%1(function) requires one literal argument.").arg(*defName));
return; return;
} else if (m_tmp == statics.strreturn) { } else if (m_tmp == statics.strreturn) {
if (m_blockstack.top().nest & NestFunction) {
if (argc > 1) { if (argc > 1) {
parseError(fL1S("return() requires zero or one argument.")); parseError(fL1S("return() requires zero or one argument."));
bogusTest(tokPtr); bogusTest(tokPtr);
return; return;
} }
} else {
if (*uce != TokFuncTerminator) {
parseError(fL1S("Top-level return() requires zero arguments."));
bogusTest(tokPtr);
return;
}
}
defType = TokReturn; defType = TokReturn;
nest = NestFunction;
goto ctrlstm2; goto ctrlstm2;
} else if (m_tmp == statics.strnext) { } else if (m_tmp == statics.strnext) {
defType = TokNext; defType = TokNext;
@ -1120,15 +1126,14 @@ void QMakeParser::finalizeCall(ushort *&tokPtr, ushort *uc, ushort *ptr, int arg
bogusTest(tokPtr); bogusTest(tokPtr);
return; return;
} }
nest = NestLoop; if (!(m_blockstack.top().nest & NestLoop)) {
ctrlstm2: parseError(fL1S("Unexpected %1().").arg(m_tmp));
if (m_invert) {
parseError(fL1S("Unexpected NOT operator in front of %1().").arg(m_tmp));
bogusTest(tokPtr); bogusTest(tokPtr);
return; return;
} }
if (!(m_blockstack.top().nest & nest)) { ctrlstm2:
parseError(fL1S("Unexpected %1().").arg(m_tmp)); if (m_invert) {
parseError(fL1S("Unexpected NOT operator in front of %1().").arg(m_tmp));
bogusTest(tokPtr); bogusTest(tokPtr);
return; return;
} }