1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show warning when setting new default QSurfaceFormat

Browse Source 
If a global shared context is created, and afterwards a new default
QSurfaceFormat with a different version or profile is set, it can
lead to issues with context sharing.
The documentation for QSurfaceFormat::setDefaultFormat mentions
this. It would be helpful to actually show a warning in case it
happens.

Change-Id: I71f7ce95496e1ecbfc6a0c7d7bed146ef8dc351e
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
This commit is contained in:
Alexandru Croitor 2016-02-11 16:28:57 +01:00 committed by Alexandru Croitor
parent d023b300b2
commit 51767affb3
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gui/kernel/qsurfaceformat.cpp
View File

@ -35,6 +35,7 @@
#include <QtCore/qatomic.h> #include <QtCore/qatomic.h>
#include <QtCore/QDebug> #include <QtCore/QDebug>
#include <QOpenGLContext>
#ifdef major #ifdef major
#undef major #undef major
@ -758,6 +759,11 @@ Q_GLOBAL_STATIC(QSurfaceFormat, qt_default_surface_format)
*/ */
void QSurfaceFormat::setDefaultFormat(const QSurfaceFormat &format) void QSurfaceFormat::setDefaultFormat(const QSurfaceFormat &format)
{ {
QOpenGLContext *globalContext = QOpenGLContext::globalShareContext();
if (globalContext && globalContext->isValid()) {
qWarning("Warning: Setting a new default format with a different version or profile after "
"the global shared context is created may cause issues with context sharing.");
}
*qt_default_surface_format() = format; *qt_default_surface_format() = format;
} }