From 511e7fc9e8b8d048a3c54c863b6378fb85f06dad Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 18 Jun 2024 21:42:30 +0200 Subject: [PATCH] tst_QFormDataBuilder: QVERIFY that QIODevice::open() succeeded ... so we don't have to guess around when the follow-up checkBodyPartsAreEquivalent() fails. Task-number: QTBUG-125985 Change-Id: I008eb7a1fa1c5457a5405838730d9e98b1cc20b4 Reviewed-by: Juha Vuolle (cherry picked from commit 4da130838ba0a0f4f7c659f8c58f7bb4304b032c) Reviewed-by: Qt Cherry-pick Bot --- .../access/qformdatabuilder/tst_qformdatabuilder.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/auto/network/access/qformdatabuilder/tst_qformdatabuilder.cpp b/tests/auto/network/access/qformdatabuilder/tst_qformdatabuilder.cpp index bc6c4b44f01..af1a581ac5b 100644 --- a/tests/auto/network/access/qformdatabuilder/tst_qformdatabuilder.cpp +++ b/tests/auto/network/access/qformdatabuilder/tst_qformdatabuilder.cpp @@ -403,7 +403,7 @@ void tst_QFormDataBuilder::moveSemantics() std::unique_ptr mp = qfdb.buildMultiPart(); auto mp_priv = QHttpMultiPartPrivate::get(mp.get()); - mp_priv->device->open(QIODeviceBase::ReadOnly); + QVERIFY(mp_priv->device->open(QIODeviceBase::ReadOnly)); const QByteArray actual = mp_priv->device->readAll(); checkBodyPartsAreEquivalent(expected, actual); @@ -422,7 +422,7 @@ void tst_QFormDataBuilder::moveSemantics() std::unique_ptr mp = qfdb_moved.buildMultiPart(); auto mp_priv = QHttpMultiPartPrivate::get(mp.get()); - mp_priv->device->open(QIODeviceBase::ReadOnly); + QVERIFY(mp_priv->device->open(QIODeviceBase::ReadOnly)); const QByteArray actual = mp_priv->device->readAll(); checkBodyPartsAreEquivalent(expected, actual); @@ -442,7 +442,7 @@ void tst_QFormDataBuilder::moveSemantics() std::unique_ptr mp = qfdb_moved.buildMultiPart(); auto mp_priv = QHttpMultiPartPrivate::get(mp.get()); - mp_priv->device->open(QIODeviceBase::ReadOnly); + QVERIFY(mp_priv->device->open(QIODeviceBase::ReadOnly)); const QByteArray actual = mp_priv->device->readAll(); checkBodyPartsAreEquivalent(expected, actual);