1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QTest::CrashHandler: switch to execvp() instead of execlp()

Browse Source 
There will be variable options.

Change-Id: Ie633615daeac87e8bd2cfffd962666a85d91d5cd
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Thiago Macieira 2025-05-14 17:54:06 -07:00
parent c8d3d7a7af
commit 4fcd854657
1 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/testlib/qtestcrashhandler_unix.cpp
View File

@ -383,20 +383,39 @@ void generateStackTrace()
// child process
(void) dup2(STDERR_FILENO, STDOUT_FILENO); // redirect stdout to stderr
struct Args {
std::array<const char *, 16> argv;
int count = 0;
Args &operator<<(const char *arg)
{
Q_ASSERT(count < int(argv.size()));
argv[count++] = arg;
return *this;
}
operator char **() const { return const_cast<char **>(argv.data()); }
} argv;
switch (debugger) {
case None:
Q_UNREACHABLE();
break;
case Gdb:
execlp("gdb", "gdb", "--nx", "--batch", "-ex", "thread apply all bt",
"-ex", "info proc mappings",
"--pid", pidbuffer.array.data(), nullptr);
argv << "gdb" << "--nx" << "--batch"
<< "-ex" << "thread apply all bt"
<< "-ex" << "printf \"\\n\""
<< "-ex" << "info proc mappings"
<< "--pid";
break;
case Lldb:
execlp("lldb", "lldb", "--no-lldbinit", "--batch", "-o", "bt all",
"--attach-pid", pidbuffer.array.data(), nullptr);
argv << "lldb" << "--no-lldbinit" << "--batch"
<< "-o" << "bt all"
<< "--attach-pid";
break;
}
if (argv.count) {
argv << pidbuffer.array.data() << nullptr;
execvp(argv.argv[0], argv);
}
_exit(1);
} else if (pid < 0) {
writeToStderr("Failed to start debugger.\n");