1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Android: Create QtWindow layout and set parent in the calling thread

Browse Source 
In the QtWindow constructor, creation of the layout and setting
the parent window were posted on the Android UI thread, leading
to them being called at a later point. If QAndroidPlatformWindow
did not have a parent at the point it was created in, but
setParent() was called shortly after, the QtWindow.setParent()
call with the actual intended parent got invoked before the
Runnable posted in the constructor got ran, leading to the
parent being overwritten with the null one passed to the
constructor, essentially leaving the QtWindow as a top level
one, while the QAndroidPlatformWindow was a child window.

The above would happen more often with foreign child windows,
sometimes causing hang ups when the parent of the foreign
child window was shown.

Creating the QtLayout outside of the Android UI thread seems
to be safe, as long as we only modify its view hierarchy inside
it.

Task-number: QTBUG-116187
Change-Id: If1ed1983f5d6ba56e625148ee6a61771234a2aa1
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
(cherry picked from commit 8df46c8890a843a651c86d198540d6318dbaa9a1)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tinja Paavoseppä 2024-01-30 10:13:42 +02:00 committed by Qt Cherry-pick Bot
parent a114fd524e
commit 4f6cbed4db
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/android/jar/src/org/qtproject/qt/android/QtWindow.java
View File

@ -29,9 +29,9 @@ public class QtWindow implements QtSurfaceInterface, QtLayout.QtTouchListener {
public QtWindow(Context context, QtWindow parentWindow) public QtWindow(Context context, QtWindow parentWindow)
{ {
m_id = View.generateViewId(); m_id = View.generateViewId();
m_layout = new QtLayout(context, this);
setParent(parentWindow);
QtNative.runAction(() -> { QtNative.runAction(() -> {
m_layout = new QtLayout(context, this);
setParent(parentWindow);
m_gestureDetector = m_gestureDetector =
new GestureDetector(context, new GestureDetector.SimpleOnGestureListener() { new GestureDetector(context, new GestureDetector.SimpleOnGestureListener() {
public void onLongPress(MotionEvent event) { public void onLongPress(MotionEvent event) {