From 4e7f906b0301803ee4045b37cd9a25ede21cc086 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 12 Apr 2024 13:55:32 -0700 Subject: [PATCH] tst_QVariant: fix copy & paste error in double-float comparisons We wanted to test the (min,max) of each of the two types, but one of the four combinations wasn't correctly done. Task-number: QTBUG-124349 Change-Id: Ie28eadac333c4bcd8c08fffd17c5a3ccb4205139 Reviewed-by: Edward Welbourne Reviewed-by: Giuseppe D'Angelo (cherry picked from commit d204ea98730baeeb55d2da229f2ce743df8c583e) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp index 84456a57b2a..ffd7bffda43 100644 --- a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp +++ b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp @@ -3162,7 +3162,7 @@ QT_WARNING_POP addComparePair(qQNaN(), std::numeric_limits::quiet_NaN()); if (sizeof(qreal) == sizeof(double)) { addComparePair(std::numeric_limits::min(), std::numeric_limits::min()); - addComparePair(std::numeric_limits::min(), std::numeric_limits::min()); + addComparePair(std::numeric_limits::min(), std::numeric_limits::max()); addComparePair(std::numeric_limits::max(), std::numeric_limits::min()); addComparePair(std::numeric_limits::max(), std::numeric_limits::max()); addComparePair(double(Q_INT64_C(1) << 53), Q_INT64_C(1) << 53);