From 4b9631359bd3c1cae7344846193e3d10c3a54725 Mon Sep 17 00:00:00 2001 From: Christian Ehrlicher Date: Tue, 15 Oct 2024 14:13:02 +0200 Subject: [PATCH] Tests/QSqlQuery: fix tst_QSqlQuery::lastInsertId() for PostgreSQL Fix tst_QSqlQuery::lastInsertId() for PostgreSQL - there must be no other query inbetween insert and lastval() to acutally receive the correct last inserted id. Pick-to: 6.8 Change-Id: I6c5bda4b1e54ec89b80caa6abf7afcc9cfe1e28b Reviewed-by: Axel Spoerl --- tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp b/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp index 653c898cbc7..4ed8b494615 100644 --- a/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp +++ b/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp @@ -2794,11 +2794,12 @@ void tst_QSqlQuery::lastInsertId() .arg(ts.tableName()))); QVERIFY_SQL(q, exec(QLatin1String("insert into %1 (t_varchar, t_char) values " "('VarChar41', 'Char41')").arg(ts.tableName()))); + QVERIFY(q.lastInsertId().isValid()); } else { QVERIFY_SQL(q, exec(QLatin1String("insert into %1 (id, t_varchar, t_char) values (41, 'VarChar41', 'Char41')") .arg(qtest))); + QVERIFY(q.lastInsertId().isValid()); } - QVERIFY(q.lastInsertId().isValid()); } void tst_QSqlQuery::lastQuery()