From 49d94bbb41cede41ebe97004a84b2e3a4f5936e5 Mon Sep 17 00:00:00 2001 From: Ievgenii Meshcheriakov Date: Thu, 30 Sep 2021 14:40:33 +0200 Subject: [PATCH] Assume that header is always present This header is a C++17 feature that is already used unconditionally in qtypeinfo.h. Change-Id: I26330d298e95102f3e94c0c69fc95c1025666eb4 Reviewed-by: Fabian Kosmale Reviewed-by: Edward Welbourne --- src/corelib/kernel/qvariant.h | 9 --------- tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp | 4 ---- 2 files changed, 13 deletions(-) diff --git a/src/corelib/kernel/qvariant.h b/src/corelib/kernel/qvariant.h index 213368a036b..bacaa44e95d 100644 --- a/src/corelib/kernel/qvariant.h +++ b/src/corelib/kernel/qvariant.h @@ -57,12 +57,7 @@ #endif #include #include - -#if __has_include() #include -#elif defined(Q_CLANG_QDOC) -namespace std { template struct variant; } -#endif QT_BEGIN_NAMESPACE @@ -402,7 +397,6 @@ class Q_CORE_EXPORT QVariant return QVariant(QMetaType::fromType(), std::addressof(value)); } -#if __has_include() || defined(Q_CLANG_QDOC) template static inline QVariant fromStdVariant(const std::variant &value) { @@ -410,7 +404,6 @@ class Q_CORE_EXPORT QVariant return QVariant(); return std::visit([](const auto &arg) { return fromValue(arg); }, value); } -#endif template bool canConvert() const @@ -580,13 +573,11 @@ inline QVariant QVariant::fromValue(const QVariant &value) return value; } -#if __has_include() template<> inline QVariant QVariant::fromValue(const std::monostate &) { return QVariant(); } -#endif inline bool QVariant::isValid() const { diff --git a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp index 40dfb79cff9..6166c8a639c 100644 --- a/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp +++ b/tests/auto/corelib/kernel/qvariant/tst_qvariant.cpp @@ -48,9 +48,7 @@ #include #include #include -#if __has_include() #include -#endif #include #include #include @@ -4882,7 +4880,6 @@ void tst_QVariant::shouldDeleteVariantDataWorksForAssociative() void tst_QVariant::fromStdVariant() { -#if __has_include() { typedef std::variant intorbool_t; intorbool_t stdvar = 5; @@ -4913,7 +4910,6 @@ void tst_QVariant::fromStdVariant() QCOMPARE(qvar.type(), QVariant::Char); QCOMPARE(qvar.value(), std::get(stdvar)); } -#endif } void tst_QVariant::qt4UuidDataStream()