1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid a potential crash in unignoredChildren

Browse Source 
This doesn't actually fix the source of the problem, but its harmless.
This was reproduced with tst_qcolumnview and voiceover enabled

Task-number: QTBUG-32440

Change-Id: Iad27884e1ca9194f911271c16908ef358e4b1875
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
This commit is contained in:
Jan Arve Saether 2013-08-09 16:14:10 +02:00 committed by The Qt Project
parent 88083a8159
commit 490bf800e6
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/platforms/cocoa/qcocoaaccessibility.mm
View File

@ -231,8 +231,7 @@ NSArray *unignoredChildren(id parentObject, QAccessibleInterface *interface)
NSMutableArray *kids = [NSMutableArray arrayWithCapacity:numKids]; NSMutableArray *kids = [NSMutableArray arrayWithCapacity:numKids];
for (int i = 0; i < numKids; ++i) { for (int i = 0; i < numKids; ++i) {
QAccessibleInterface *child = interface->child(i); QAccessibleInterface *child = interface->child(i);
Q_ASSERT(child); if (!child || !child->isValid() || child->state().invalid || child->state().invisible)
if (child->state().invalid || child->state().invisible)
continue; continue;
QAccessible::Id childId = QAccessible::uniqueId(child); QAccessible::Id childId = QAccessible::uniqueId(child);