1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bench QSet::unite

Browse Source 
It was shown to have poor performance compared to contains() and
insert().

Pick-to: 6.6 6.5
Change-Id: I61cfbc8c34e325d677d7954118ef68057df640cb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 000cb2dadc16e5bd585da459de44f1902943ea56)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Mårten Nordheim 2024-01-18 12:28:36 +01:00 committed by Qt Cherry-pick Bot
parent a06a78bb04
commit 482962ffca
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
tests/benchmarks/corelib/tools/qset/tst_bench_qset.cpp
View File

@ -14,6 +14,10 @@ private slots:
void intersect_int();
void intersect_complexType_data();
void intersect_complexType();
void unite_int_data();
void unite_int();
void contains_then_insert_int_data();
void contains_then_insert_int();
};
void tst_QSet::initTestCase()
@ -104,6 +108,70 @@ void tst_QSet::intersect_complexType()
}
}
void tst_QSet::unite_int_data()
{
QTest::addColumn<int>("lhsSize");
QTest::addColumn<int>("rhsSize");
QTest::addColumn<int>("overlap");
QTest::newRow("1000000.unite(1000) - 0 overlap") << 1000000 << 1000 << 0;
QTest::newRow("1000000.unite(1000) - 100 overlap") << 1000000 << 1000 << 100;
QTest::newRow("1000000.unite(1000) - 1000 overlap") << 1000000 << 1000 << 1000;
QTest::newRow("1000.unite(1000000) - 0 overlap") << 1000 << 1000000 << 0;
QTest::newRow("1000.unite(1000000) - 100 overlap") << 1000 << 1000000 << 100;
QTest::newRow("1000.unite(1000000) - 1000 overlap") << 1000 << 1000000 << 1000;
}
auto build_sets(int lhsSize, int rhsSize, int overlap)
{
QSet<int> lhs;
for (int i = 0; i < lhsSize; ++i)
lhs.insert(i);
QSet<int> rhs;
for (int i = lhsSize - overlap; i < rhsSize + lhsSize - overlap; ++i)
rhs.insert(i);
return std::make_pair(lhs, rhs);
}
void tst_QSet::unite_int()
{
QFETCH(int, lhsSize);
QFETCH(int, rhsSize);
QFETCH(int, overlap);
auto [lhs, rhs] = build_sets(lhsSize, rhsSize, overlap);
QBENCHMARK {
QSet united = QSet(lhs).unite(rhs);
QCOMPARE(united.size(), lhsSize + rhsSize - overlap);
}
}
void tst_QSet::contains_then_insert_int_data()
{
unite_int_data();
}
void tst_QSet::contains_then_insert_int()
{
QFETCH(int, lhsSize);
QFETCH(int, rhsSize);
QFETCH(int, overlap);
auto [lhs, rhs] = build_sets(lhsSize, rhsSize, overlap);
QBENCHMARK {
QSet copy(lhs);
for (auto i : rhs) {
if (!copy.contains(i))
copy.insert(i);
}
QCOMPARE(copy.size(), lhsSize + rhsSize - overlap);
}
}
QTEST_MAIN(tst_QSet)
#include "tst_bench_qset.moc"