1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QSqlQuery tests: fix bool test for postgresql

Browse Source 
Change-Id: I60634f89841cbc81058588e435c6482c6c0efed6
Reviewed-by: Mark Brand <mabrand@mabrand.nl>
This commit is contained in:
Mark Brand 2013-02-11 21:14:00 +01:00 committed by The Qt Project
parent f01caaf64a
commit 46b7c91c81
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
View File

@ -580,9 +580,10 @@ void tst_QSqlQuery::mysqlOutValues()
void tst_QSqlQuery::bindBool() void tst_QSqlQuery::bindBool()
{ {
// QTBUG-27763: bool value got converted to int 127 by mysql driver because sizeof(bool) < sizeof(int). // QTBUG-27763: bool value got converted to int 127 by mysql driver because sizeof(bool) < sizeof(int).
// The problem was the way the bool value from the application was handled. It doesn't matter // The problem was the way the bool value from the application was handled. For our purposes here, it
// whether the table column type is BOOL or INT. Use INT here because all DBMSs have it and all // doesn't matter whether the column type is BOOLEAN or INT. All DBMSs have INT, and this usually
// should pass this test. // works for this test. Postresql is an exception because its INT type does not accept BOOLEAN
// values and its BOOLEAN columns do not accept INT values.
QFETCH( QString, dbName ); QFETCH( QString, dbName );
QSqlDatabase db = QSqlDatabase::database( dbName ); QSqlDatabase db = QSqlDatabase::database( dbName );
CHECK_DATABASE( db ); CHECK_DATABASE( db );
@ -590,7 +591,8 @@ void tst_QSqlQuery::bindBool()
const QString tableName(qTableName( "bindBool", __FILE__ )); const QString tableName(qTableName( "bindBool", __FILE__ ));
q.exec("DROP TABLE " + tableName); q.exec("DROP TABLE " + tableName);
QVERIFY_SQL(q, exec("CREATE TABLE " + tableName + " (id INT, flag INT NOT NULL, PRIMARY KEY(id))")); QString colType = db.driverName().startsWith("QPSQL") ? QLatin1String("BOOLEAN") : QLatin1String("INT");
QVERIFY_SQL(q, exec("CREATE TABLE " + tableName + " (id INT, flag " + colType + " NOT NULL, PRIMARY KEY(id))"));
for (int i = 0; i < 2; ++i) { for (int i = 0; i < 2; ++i) {
bool flag = i; bool flag = i;