1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Torrent example: Fix some stack overflow issues

Browse Source 
Because of the .size() used as part of the expression it
ends up copying sizeof(qsizetype) bytes to the array,
instead of the (rationally) expected 4 bytes.

Amends 69c31f6f68a1399c1fc1e545e318eaa40966fe85

Task-number: QTBUG-110622
Change-Id: I732e3f4bb5934ff3860087baa91f9bebbf044a7f
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Reviewed-by: Konrad Kujawa <konrad.kujawa@qt.io>
(cherry picked from commit f3de92cdad7642e6c3425712823e1491768f2e56)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Mårten Nordheim 2023-02-20 13:02:29 +01:00 committed by Qt Cherry-pick Bot
parent f97235c459
commit 44eabe2f93
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/network/torrent/peerwireclient.cpp
View File

@ -177,7 +177,7 @@ void PeerWireClient::sendPieceList(const QBitArray &bitField)
} }
char message[] = {0, 0, 0, 1, 5}; char message[] = {0, 0, 0, 1, 5};
qToBigEndian(bits.size() + 1, &message[0]); qToBigEndian<qint32>(bits.size() + 1, &message[0]);
write(message, sizeof(message)); write(message, sizeof(message));
write(bits); write(bits);
} }
@ -227,7 +227,7 @@ void PeerWireClient::sendBlock(int piece, int offset, const QByteArray &data)
QByteArray block; QByteArray block;
char message[] = {0, 0, 0, 1, 7}; char message[] = {0, 0, 0, 1, 7};
qToBigEndian(9 + data.size(), &message[0]); qToBigEndian<qint32>(9 + data.size(), &message[0]);
block += QByteArray(message, sizeof(message)); block += QByteArray(message, sizeof(message));
char numbers[4 * 2]; char numbers[4 * 2];