QDataStream::readBytes(): make the growth of the buffer geometric

The algorithm tries to allocate the memory using 1 Mb blocks.
When the input data is large, this results in a lot of reallocations,
which is slow and inefficient.

This patch modifies the algorithm in such way that the allocation size
increases at each step, resulting in geometric growth of the buffer.

Pick-to: 6.6 6.5
Change-Id: I071df68d51ba1dbd8b2eb5f94eb078a33223505f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit a1bfac287ee5d3719646d68dc91dc8e8e4cec04e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Ivan Solovev 2024-02-01 11:50:25 +01:00 committed by Qt Cherry-pick Bot
parent 635be3cdf1
commit 44dc38ebc9

View File

@ -1073,13 +1073,13 @@ QDataStream &QDataStream::readBytes(char *&s, qint64 &l)
return *this;
}
constexpr qsizetype Step = 1024 * 1024;
qsizetype step = 1024 * 1024;
qsizetype allocated = 0;
char *prevBuf = nullptr;
char *curBuf = nullptr;
do {
qsizetype blockSize = qMin(Step, len - allocated);
qsizetype blockSize = qMin(step, len - allocated);
prevBuf = curBuf;
curBuf = new char[allocated + blockSize + 1];
if (prevBuf) {
@ -1091,6 +1091,7 @@ QDataStream &QDataStream::readBytes(char *&s, qint64 &l)
return *this;
}
allocated += blockSize;
step *= 2;
} while (allocated < len);
s = curBuf;