1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

client: Fix deletion of new queued shm buffers during reconnect

Browse Source 
When reconnecting the cleanup of existing buffers is delayed in order
to preserve contents and copy them to buffers belonging to the new
connection. Due to the order of events it could happen that
a new buffer was deleted along with the old ones but still being
referenced by a window.
During reconnect all QScreens are removed and new ones added for
the wl_outputs on the new connection during the initial roundtrips.
When the first new QScreen is added  all QWindows move form the placeholder
screen to it. This can cause for example QWidgets to repaint. At this point
the windows are not reinited yet, and the buffer is queued inside the window.
Only afterwards the reconnected signal was emitted which would cause
deletion of all existing buffers including the newly queued ones.
To fix this the signal is moved after the first roundtrip where all globals
are announced and new buffers can be created but no new screens have been
announced yet. The signal is renamed to be more fit for its new location.

Pick-to: 6.7
Pick-to: 6.6
Change-Id: I06be14d235ac342a4b420176aadad3ccf18178fe
Reviewed-by: David Edmundson <davidedmundson@kde.org>
This commit is contained in:
David Redondo 2024-01-22 15:33:59 +01:00
parent 91a261b6ed
commit 424abe6242
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/platforms/wayland/qwaylanddisplay.cpp
View File

@ -391,6 +391,8 @@ bool QWaylandDisplay::initialize()
forceRoundTrip();
emit connected();
if (!mWaitingScreens.isEmpty()) {
// Give wl_output.done and zxdg_output_v1.done events a chance to arrive
forceRoundTrip();
@ -481,8 +483,6 @@ void QWaylandDisplay::reconnect()
wl_event_queue_destroy(m_frameEventQueue);
initEventThread();
emit reconnected();
auto needsRecreate = [](QPlatformWindow *window) {
return window && !static_cast<QWaylandWindow *>(window)->wlSurface();
};

2
src/plugins/platforms/wayland/qwaylanddisplay_p.h
View File

@ -259,7 +259,7 @@ public Q_SLOTS:
void flushRequests();
Q_SIGNALS:
void reconnected();
void connected();
void globalAdded(const RegistryGlobal &global);
void globalRemoved(const RegistryGlobal &global);

2
src/plugins/platforms/wayland/qwaylandshmbackingstore.cpp
View File

@ -137,7 +137,7 @@ QWaylandShmBackingStore::QWaylandShmBackingStore(QWindow *window, QWaylandDispla
: QPlatformBackingStore(window)
, mDisplay(display)
{
QObject::connect(mDisplay, &QWaylandDisplay::reconnected, window, [this]() {
QObject::connect(mDisplay, &QWaylandDisplay::connected, window, [this]() {
auto copy = mBuffers;
// clear available buffers so we create new ones
// actual deletion is deferred till after resize call so we can copy