From 40592d38f86129de7efc22b80ec832aaa6fa6b6b Mon Sep 17 00:00:00 2001
From: Marc Mutz <marc.mutz@qt.io>
Date: Thu, 7 Dec 2023 00:24:10 +0100
Subject: [PATCH] QSpan: add some C++20 reminder code comments

Change-Id: I1cd698bde290cbd37d13103cd6832a739d9c548b
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
---
 src/corelib/tools/qspan.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/corelib/tools/qspan.h b/src/corelib/tools/qspan.h
index 35f44ebd87b..5137416fafc 100644
--- a/src/corelib/tools/qspan.h
+++ b/src/corelib/tools/qspan.h
@@ -97,6 +97,7 @@ class QSpanCommon {
 protected:
     template <typename Iterator>
     using is_compatible_iterator = std::conjunction<
+            // ### C++20: extend to contiguous_iteratorss
             std::is_base_of<
                 std::random_access_iterator_tag,
                 typename std::iterator_traits<Iterator>::iterator_category
@@ -108,6 +109,7 @@ protected:
         >;
     template <typename Iterator, typename End>
     using is_compatible_iterator_and_sentinel = std::conjunction<
+            // ### C++20: extend to contiguous_iterators and real sentinels
             is_compatible_iterator<Iterator>,
             std::negation<std::is_convertible<End, std::size_t>>
         >;
@@ -118,7 +120,7 @@ protected:
         : is_compatible_iterator<QSpanPrivate::iterator_t<Range>> {};
     template <typename Range>
     using is_compatible_range = std::conjunction<
-            // ### this needs more work, esp. extension to C++20 contiguous iterators
+            // ### C++20: extend to contiguous_iterators
             std::negation<is_qspan<Range>>,
             std::negation<is_std_span<Range>>,
             std::negation<is_std_array<Range>>,