From 404b1fd8b351c5e23a283a21a621e35cdd24a6e4 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 16 Dec 2015 01:43:17 +0100 Subject: [PATCH] QFlickGestureRecognizer: remove a useless check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There's no point in checking isEmpty() to prevent a for loop from executing, esp. if the checking involves copying the container and calling an out-of-line function to get said copy. Just fall through the for loop. Change-Id: If6c689ff4bcd685bc645b4fb3f2c15ce5d5945af Reviewed-by: Sérgio Martins Reviewed-by: Friedemann Kleint --- src/widgets/util/qflickgesture.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/widgets/util/qflickgesture.cpp b/src/widgets/util/qflickgesture.cpp index 6d23977dc09..b240902ced2 100644 --- a/src/widgets/util/qflickgesture.cpp +++ b/src/widgets/util/qflickgesture.cpp @@ -583,7 +583,7 @@ QGestureRecognizer::Result QFlickGestureRecognizer::recognize(QGesture *state, scrollerRegion = QRect(w->mapToGlobal(QPoint(0, 0)), w->size()); #ifndef QT_NO_GRAPHICSVIEW } else if (QGraphicsObject *go = qobject_cast(as->target())) { - if (go->scene() && !go->scene()->views().isEmpty()) { + if (go->scene()) { foreach (QGraphicsView *gv, go->scene()->views()) scrollerRegion |= gv->mapFromScene(go->mapToScene(go->boundingRect())) .translated(gv->mapToGlobal(QPoint(0, 0)));